Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--seeder pip does not work with --extra-search-dir #1834

Closed
frenzymadness opened this issue May 19, 2020 · 1 comment · Fixed by #1835
Closed

--seeder pip does not work with --extra-search-dir #1834

frenzymadness opened this issue May 19, 2020 · 1 comment · Fixed by #1835
Labels

Comments

@frenzymadness
Copy link
Contributor

@frenzymadness frenzymadness commented May 19, 2020

Issue

The problem is here. When one or more extra search dir is specified, the resulting command looks like this [<python>, '-m', 'pip', '-q', 'install', '--only-binary', ':all:', '--no-index', 'pip', 'setuptools', 'wheel', '--find-links', '/usr/lib/python3.8/site-packages/virtualenv/seed/embed/wheels', [extra dir one], [extra dir two]]. Which leads to pip tries to install [extra dir one] as a package and error message: ERROR: Directory '[extra dir one]' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.

pip needs to have each directory specified with --find-links so the command should look like this: [<python>, '-m', 'pip', '-q', 'install', '--only-binary', ':all:', '--no-index', 'pip', 'setuptools', 'wheel', '--find-links', '/usr/lib/python3.8/site-packages/virtualenv/seed/embed/wheels', '--find-links', [extra dir one], '--find-links', [extra dir two]].

I'll open a PR for this.

frenzymadness added a commit to frenzymadness/virtualenv that referenced this issue May 19, 2020
pip needs to have `--find-links` CLI argument for each directory
not just once for a list of directories.

Fixes: pypa#1834
frenzymadness added a commit to frenzymadness/virtualenv that referenced this issue May 20, 2020
pip needs to have `--find-links` CLI argument for each directory
not just once for a list of directories.

Fixes: pypa#1834
@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented May 20, 2020

@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants