New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell fixes #1258

Merged
merged 19 commits into from Dec 23, 2018

Conversation

Projects
None yet
2 participants
@gaborbernat
Copy link
Contributor

gaborbernat commented Dec 18, 2018

馃憤

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch from 393da88 to c0142b1 Dec 18, 2018

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch 20 times, most recently from ded9f59 to a3aa89f Dec 18, 2018

ViViDboarder added some commits Feb 26, 2016

Always store _OLD_VIRTUAL_PATH in a sh compat format
When using a subshell from fish while within a virtualenv the
_OLD_VIRTUAL_PATH variable ends up in fish format and not the format of
the subshell. This breaks the first step of the activate script where it
attepts to deactivate the previous environment.

This patch will handle conversion to and from sh and fish formats within
the activate.fish script
Fix lint
Remove line that didn't lint as we don't need it.

gaborbernat added some commits Dec 18, 2018

Consolidate activation testing
- add tests for csh, bash
- rework bash, csh tests
- remove powershell singing
- powershell pydoc support

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch 5 times, most recently from 7d6faa2 to 45322c9 Dec 21, 2018

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch from 45322c9 to eba35b4 Dec 21, 2018

gaborbernat added some commits Dec 21, 2018

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch from 51fd27a to f0941a5 Dec 22, 2018

gaborbernat added some commits Dec 22, 2018

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch 7 times, most recently from 78c01e9 to 4f61f99 Dec 22, 2018

@gaborbernat gaborbernat force-pushed the gaborbernat:shell-fixes branch from 4f61f99 to 40fb89c Dec 23, 2018

@gaborbernat gaborbernat merged commit 34fdfb5 into pypa:master Dec 23, 2018

@gaborbernat gaborbernat deleted the gaborbernat:shell-fixes branch Dec 23, 2018

@gaborbernat gaborbernat added this to the 16.2 milestone Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment