New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResourceWarning: unclosed file #1277

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@BoboTiG
Copy link
Contributor

BoboTiG commented Jan 2, 2019

Thanks for contributing a pull request, see checklist all is good!

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder

Description

Such warning is fired when enabling PYTHONWARNINGS:

virtualenv.py:983 unclosed file <_io.BufferedReader name=26>'

BoboTiG added some commits Jan 2, 2019

@gaborbernat gaborbernat merged commit ee01c10 into pypa:master Jan 3, 2019

1 check passed

pypa.virtualenv #pypa.virtualenv_20190102.03 succeeded
Details
@gaborbernat

This comment has been minimized.

Copy link
Contributor

gaborbernat commented Jan 3, 2019

thanks!

@BoboTiG BoboTiG deleted the BoboTiG:fix-resource-leak branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment