Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further fix for #1339 (--python option) #1364

Merged
merged 4 commits into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@pfmoore
Copy link
Member

commented Jun 3, 2019

No description provided.

pfmoore added some commits Jun 3, 2019

@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

Hmm, I'm getting test errors saying "ERROR: target path contains the operating system path separator ';'". That doesn't seem related to my change (and I think there was a recent change merged to do with that). So is there some other issue with master? @gaborbernat

Having said that, there do seem to be some issues with my code - but I'm not clear what yet. I'm working on those :-)

@gaborbernat gaborbernat merged commit a401061 into pypa:master Jun 3, 2019

1 check passed

pypa.virtualenv #pypa.virtualenv_20190603.17 succeeded
Details
@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

Thanks for the fast merge!

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

I thank you for the fast fix. Release will take a week or two as I'm in middle of multiple major changes. Will be inside release 17.0.0 though 😁

@gaborbernat gaborbernat added this to the 17.0.0 milestone Jun 3, 2019

@pfmoore

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

No worries, it's been hitting me personally, so I was well motivated to find a fix :-) And I can use the version from github until the release arrives, so we're good there.

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

FYI will move to src layout soon, so use pep-517+518 to install from GitHub 😁

@asottile

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Awesome, just did some debugging / spelunking to find this solves the issue I'm seeing as well in pre-commit/pre-commit#1046

looking forward to the release!

fwiw my reproduction was a little more involved for whatever reason:

python -mvirtualenv venv2 -p 'C:\Users\Anthony\AppData\Local\Temp\t\x\vvv\Scripts\python.exe'
@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

I'll release tomorrow as a patch release 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.