Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for python 3.10 #1385

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@asottile
Copy link
Contributor

commented Jul 18, 2019

I'm using a hacked up python to try and squash some bugs long before they're a problem: https://launchpad.net/~asottile/+archive/ubuntu/python3.10

Here's a quick demo:

$ python3.10 virtualenv.py venv10
Using base prefix '/usr'
New python executable in /home/asottile/workspace/virtualenv/venv10/bin/python3.10
Also creating executable in /home/asottile/workspace/virtualenv/venv10/bin/python
Installing setuptools, pip, wheel...
done.
$ venv10/bin/python --version
Python 3.10.0a0
$ venv10/bin/python -c 'import sys; print(sys.path)'
['', '/home/asottile/workspace/virtualenv/venv10/lib/python31.zip', '/home/asottile/workspace/virtualenv/venv10/lib/python3.10', '/home/asottile/workspace/virtualenv/venv10/lib/python3.10/lib-dynload', '/usr/lib/python3.10', '/home/asottile/workspace/virtualenv/venv10/lib/python3.10/site-packages']
@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Feels a bit premature with the major rewrite in progress 😃

@asottile

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

Mmmmm I was hoping to get this merged as a bugfix so I can fix tox (and then other things). I assume even with the rewrite some or most of this code will be necessary for continued python 2 support

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

No changelog entry? 😢

@gaborbernat gaborbernat merged commit 311a909 into pypa:master Jul 23, 2019

1 check was pending

pypa.virtualenv in progress
Details

@asottile asottile deleted the asottile:3_10_fixes branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.