Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error when not sourcing activate scripts (#1372) #1388

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@joaoe
Copy link
Contributor

commented Jul 19, 2019

The activate scripts are to be used in the context of the current shell session.

The feature so far only works in powershell and bash, because in other shells it
is hard to get the name of the currently executing script.

Also added tests.

Thanks for contributing a pull request, see checklist all is good!

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder

joaoe and others added some commits Jun 24, 2019

Report error when not sourcing activate scripts (#1372)
The activate scripts are to be used in the context of the current shell session.

The feature so far only works in powershell and bash, because in other shells it
is hard to get the name of the currently executing script.

Also added tests.
fix
@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Please allow modification by maintainers.

@gaborbernat gaborbernat merged commit e81ffe0 into pypa:master Jul 23, 2019

1 check failed

pypa.virtualenv #pypa.virtualenv_20190723.06 failed
Details
@joaoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.