Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bashism preventing virtualenv in sh #1396

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@kojiromike
Copy link
Contributor

commented Jul 25, 2019

In #1372 a bug was introduced making activate fail in non-bash sh shells. This fixes it.

Thanks for contributing a pull request, see checklist all is good!

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder
Fix bashism preventing virtualenv in sh
In #1372 a bug was introduced making activate fail in non-bash sh shells. This fixes it.

@gaborbernat gaborbernat merged commit 6ab16b3 into pypa:master Jul 26, 2019

1 check passed

pypa.virtualenv #pypa.virtualenv_20190726.01 succeeded
Details

@kojiromike kojiromike deleted the kojiromike:sh-friendly branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.