Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require passing a destination directory #1568

Merged
merged 1 commit into from Feb 11, 2020
Merged

Conversation

@pradyunsg
Copy link
Member

pradyunsg commented Feb 11, 2020

Resolves #1556

@pradyunsg

This comment has been minimized.

Copy link
Member Author

pradyunsg commented Feb 11, 2020

Note to self: need to update documentation, since there's at least one section w/ prose that suggests passing no-args will work.

@pradyunsg pradyunsg marked this pull request as ready for review Feb 11, 2020
@gaborbernat gaborbernat force-pushed the pradyunsg:require-dest branch 3 times, most recently from bbdef9d to 393dee6 Feb 11, 2020
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the pradyunsg:require-dest branch from 393dee6 to fcf6f89 Feb 11, 2020
@gaborbernat gaborbernat changed the title Require passing a destination directory require passing a destination directory Feb 11, 2020
@nsoranzo

This comment has been minimized.

Copy link

nsoranzo commented Feb 11, 2020

I think the description should say: "Resolves #1556"

@gaborbernat gaborbernat merged commit 0e00194 into pypa:master Feb 11, 2020
33 of 34 checks passed
33 of 34 checks passed
pypa.virtualenv Build #pypa.virtualenv_20200211.29 failed
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
pypa.virtualenv (dev linux) dev linux succeeded
Details
pypa.virtualenv (docs linux) docs linux succeeded
Details
pypa.virtualenv (docs windows) docs windows succeeded
Details
pypa.virtualenv (fix_lint linux) fix_lint linux succeeded
Details
pypa.virtualenv (fix_lint windows) fix_lint windows succeeded
Details
pypa.virtualenv (py27 linux) py27 linux succeeded
Details
pypa.virtualenv (py27 macOs) py27 macOs succeeded
Details
pypa.virtualenv (py27 windows) py27 windows succeeded
Details
pypa.virtualenv (py35 linux) py35 linux succeeded
Details
pypa.virtualenv (py35 macOs) py35 macOs succeeded
Details
pypa.virtualenv (py35 vs2017-win2016) py35 vs2017-win2016 succeeded
Details
pypa.virtualenv (py36 linux) py36 linux succeeded
Details
pypa.virtualenv (py36 macOs) py36 macOs succeeded
Details
pypa.virtualenv (py36 vs2017-win2016) py36 vs2017-win2016 succeeded
Details
pypa.virtualenv (py37 linux) py37 linux succeeded
Details
pypa.virtualenv (py37 macOs) py37 macOs succeeded
Details
pypa.virtualenv (py37 vs2017-win2016) py37 vs2017-win2016 succeeded
Details
pypa.virtualenv (py38 linux) py38 linux succeeded
Details
pypa.virtualenv (py38 macOs) py38 macOs succeeded
Details
pypa.virtualenv (py38 vs2017-win2016) py38 vs2017-win2016 succeeded
Details
pypa.virtualenv (pypy linux) pypy linux succeeded
Details
pypa.virtualenv (pypy macOs) pypy macOs succeeded
Details
pypa.virtualenv (pypy windows) pypy windows succeeded
Details
pypa.virtualenv (pypy3 linux) pypy3 linux succeeded
Details
pypa.virtualenv (pypy3 macOs) pypy3 macOs succeeded
Details
pypa.virtualenv (pypy3 windows) pypy3 windows succeeded
Details
pypa.virtualenv (readme linux) readme linux succeeded
Details
pypa.virtualenv (readme windows) readme windows succeeded
Details
pypa.virtualenv (upgrade linux) upgrade linux succeeded
Details
pypa.virtualenv (upgrade windows) upgrade windows succeeded
Details
pypa.virtualenv (zipapp linux) zipapp linux succeeded
Details
pypa.virtualenv (zipapp windows) zipapp windows succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.