Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower min version of six to 1.9 #1606

Merged
merged 1 commit into from Feb 13, 2020
Merged

Lower min version of six to 1.9 #1606

merged 1 commit into from Feb 13, 2020

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Feb 13, 2020

This change should allow installation of virtualenv on systems with older six where their LTS support may prevent them from upgrading it.

Fixes: #1605

@ssbarnea ssbarnea force-pushed the master branch 2 times, most recently from 94fdcab to ac1730e Compare Feb 13, 2020
@ssbarnea ssbarnea changed the title POC: Lower minversion of six Lower min version of six to 1.9 Feb 13, 2020
@ssbarnea ssbarnea marked this pull request as ready for review Feb 13, 2020
@ssbarnea ssbarnea requested a review from gaborbernat Feb 13, 2020
Copy link
Contributor

@gaborbernat gaborbernat left a comment

I'd rather keep imports as it is, and only move the ensure_text and ensure_str to our virtualenv.util.six package 👍

@gaborbernat
Copy link
Contributor

gaborbernat commented Feb 13, 2020

Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷‍♂️

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Feb 13, 2020

Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷‍♂️

Done another round, metaclass was not really needed, lets check again after it reports green.

This change should allow installation of virtualenv on systems
with older six where their LTS support may prevent them from
upgrading it.
@ssbarnea
Copy link
Contributor Author

ssbarnea commented Feb 13, 2020

AFAIK, i am done, now waiting for @gaborbernat to look again at this boring change.

@gaborbernat gaborbernat merged commit 52e4213 into pypa:master Feb 13, 2020
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants