Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower min version of six to 1.9 #1606

Merged
merged 1 commit into from Feb 13, 2020
Merged

Lower min version of six to 1.9 #1606

merged 1 commit into from Feb 13, 2020

Conversation

@ssbarnea
Copy link
Contributor

ssbarnea commented Feb 13, 2020

This change should allow installation of virtualenv on systems with older six where their LTS support may prevent them from upgrading it.

Fixes: #1605

@ssbarnea ssbarnea force-pushed the ssbarnea:master branch 2 times, most recently from 94fdcab to ac1730e Feb 13, 2020
@ssbarnea ssbarnea changed the title POC: Lower minversion of six Lower min version of six to 1.9 Feb 13, 2020
@ssbarnea ssbarnea marked this pull request as ready for review Feb 13, 2020
@ssbarnea ssbarnea requested a review from gaborbernat Feb 13, 2020
@ssbarnea ssbarnea force-pushed the ssbarnea:master branch from ac1730e to 09a90a4 Feb 13, 2020
Copy link
Contributor

gaborbernat left a comment

I'd rather keep imports as it is, and only move the ensure_text and ensure_str to our virtualenv.util.six package 👍

@ssbarnea ssbarnea force-pushed the ssbarnea:master branch from 09a90a4 to ab6cbfe Feb 13, 2020
@ssbarnea ssbarnea requested a review from gaborbernat Feb 13, 2020
@gaborbernat

This comment has been minimized.

Copy link
Contributor

gaborbernat commented Feb 13, 2020

Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷‍♂️

@ssbarnea

This comment has been minimized.

Copy link
Contributor Author

ssbarnea commented Feb 13, 2020

Let's keep all import from six other than the two ensure Which can be from virtualenv.util 🤷‍♂️

Done another round, metaclass was not really needed, lets check again after it reports green.

This change should allow installation of virtualenv on systems
with older six where their LTS support may prevent them from
upgrading it.
@ssbarnea ssbarnea force-pushed the ssbarnea:master branch from ab6cbfe to 05a74d5 Feb 13, 2020
@ssbarnea

This comment has been minimized.

Copy link
Contributor Author

ssbarnea commented Feb 13, 2020

AFAIK, i am done, now waiting for @gaborbernat to look again at this boring change.

@gaborbernat gaborbernat merged commit 52e4213 into pypa:master Feb 13, 2020
35 checks passed
35 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
pypa.virtualenv Build #pypa.virtualenv_20200213.07 succeeded
Details
pypa.virtualenv (dev linux) dev linux succeeded
Details
pypa.virtualenv (docs linux) docs linux succeeded
Details
pypa.virtualenv (docs windows) docs windows succeeded
Details
pypa.virtualenv (fix_lint linux) fix_lint linux succeeded
Details
pypa.virtualenv (fix_lint windows) fix_lint windows succeeded
Details
pypa.virtualenv (py27 linux) py27 linux succeeded
Details
pypa.virtualenv (py27 macOs) py27 macOs succeeded
Details
pypa.virtualenv (py27 windows) py27 windows succeeded
Details
pypa.virtualenv (py35 linux) py35 linux succeeded
Details
pypa.virtualenv (py35 macOs) py35 macOs succeeded
Details
pypa.virtualenv (py35 vs2017-win2016) py35 vs2017-win2016 succeeded
Details
pypa.virtualenv (py36 linux) py36 linux succeeded
Details
pypa.virtualenv (py36 macOs) py36 macOs succeeded
Details
pypa.virtualenv (py36 vs2017-win2016) py36 vs2017-win2016 succeeded
Details
pypa.virtualenv (py37 linux) py37 linux succeeded
Details
pypa.virtualenv (py37 macOs) py37 macOs succeeded
Details
pypa.virtualenv (py37 vs2017-win2016) py37 vs2017-win2016 succeeded
Details
pypa.virtualenv (py38 linux) py38 linux succeeded
Details
pypa.virtualenv (py38 macOs) py38 macOs succeeded
Details
pypa.virtualenv (py38 vs2017-win2016) py38 vs2017-win2016 succeeded
Details
pypa.virtualenv (pypy linux) pypy linux succeeded
Details
pypa.virtualenv (pypy macOs) pypy macOs succeeded
Details
pypa.virtualenv (pypy windows) pypy windows succeeded
Details
pypa.virtualenv (pypy3 linux) pypy3 linux succeeded
Details
pypa.virtualenv (pypy3 macOs) pypy3 macOs succeeded
Details
pypa.virtualenv (pypy3 windows) pypy3 windows succeeded
Details
pypa.virtualenv (readme linux) readme linux succeeded
Details
pypa.virtualenv (readme windows) readme windows succeeded
Details
pypa.virtualenv (report_coverage) report_coverage succeeded
Details
pypa.virtualenv (upgrade linux) upgrade linux succeeded
Details
pypa.virtualenv (upgrade windows) upgrade windows succeeded
Details
pypa.virtualenv (zipapp linux) zipapp linux succeeded
Details
pypa.virtualenv (zipapp windows) zipapp windows succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.