Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazonlinux support #1728

Merged
merged 2 commits into from Mar 18, 2020
Merged

amazonlinux support #1728

merged 2 commits into from Mar 18, 2020

Conversation

@gaborbernat
Copy link
Contributor

gaborbernat commented Mar 17, 2020

Resolves #1719.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat

This comment has been minimized.

Copy link
Contributor Author

gaborbernat commented Mar 17, 2020

@tzulberti can you validate that this solves your issue?

@tzulberti

This comment has been minimized.

Copy link
Contributor

tzulberti commented Mar 17, 2020

I tested this issue by doing a git clone inside a Docker image:

FROM amazonlinux:1

RUN yum -y install python27 python27-devel python36 python36-devel python27-pip git

#RUN pip-3.6 install --upgrade virtualenv
RUN pip-3.6 install --upgrade 'setuptools>=41'
RUN pip-3.6 install --upgrade wheel
RUN git clone https://github.com/gaborbernat/virtualenv.git && \
    cd virtualenv && \
    git checkout 1719 && \
    pip-3.6 install .

RUN cd /root && virtualenv --python python2.7 /tmp/bar

RUN source /tmp/bar/bin/activate && pip freeze

And it seems to work ok

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the gaborbernat:1719 branch from 175b27f to 113b15f Mar 18, 2020
@gaborbernat gaborbernat merged commit e76b56f into pypa:master Mar 18, 2020
37 checks passed
37 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
pypa.virtualenv Build #pypa.virtualenv_20200318.01 succeeded
Details
pypa.virtualenv (dev linux) dev linux succeeded
Details
pypa.virtualenv (docs linux) docs linux succeeded
Details
pypa.virtualenv (docs windows) docs windows succeeded
Details
pypa.virtualenv (fix_lint linux) fix_lint linux succeeded
Details
pypa.virtualenv (fix_lint windows) fix_lint windows succeeded
Details
pypa.virtualenv (homebrew_py2 macOs) homebrew_py2 macOs succeeded
Details
pypa.virtualenv (homebrew_py3 macOs) homebrew_py3 macOs succeeded
Details
pypa.virtualenv (py27 linux) py27 linux succeeded
Details
pypa.virtualenv (py27 macOs) py27 macOs succeeded
Details
pypa.virtualenv (py27 windows) py27 windows succeeded
Details
pypa.virtualenv (py35 linux) py35 linux succeeded
Details
pypa.virtualenv (py35 macOs) py35 macOs succeeded
Details
pypa.virtualenv (py35 vs2017-win2016) py35 vs2017-win2016 succeeded
Details
pypa.virtualenv (py36 linux) py36 linux succeeded
Details
pypa.virtualenv (py36 macOs) py36 macOs succeeded
Details
pypa.virtualenv (py36 vs2017-win2016) py36 vs2017-win2016 succeeded
Details
pypa.virtualenv (py37 linux) py37 linux succeeded
Details
pypa.virtualenv (py37 macOs) py37 macOs succeeded
Details
pypa.virtualenv (py37 vs2017-win2016) py37 vs2017-win2016 succeeded
Details
pypa.virtualenv (py38 linux) py38 linux succeeded
Details
pypa.virtualenv (py38 macOs) py38 macOs succeeded
Details
pypa.virtualenv (py38 vs2017-win2016) py38 vs2017-win2016 succeeded
Details
pypa.virtualenv (pypy linux) pypy linux succeeded
Details
pypa.virtualenv (pypy macOs) pypy macOs succeeded
Details
pypa.virtualenv (pypy windows) pypy windows succeeded
Details
pypa.virtualenv (pypy3 linux) pypy3 linux succeeded
Details
pypa.virtualenv (pypy3 macOs) pypy3 macOs succeeded
Details
pypa.virtualenv (pypy3 windows) pypy3 windows succeeded
Details
pypa.virtualenv (readme linux) readme linux succeeded
Details
pypa.virtualenv (readme windows) readme windows succeeded
Details
pypa.virtualenv (report_coverage) report_coverage succeeded
Details
pypa.virtualenv (upgrade linux) upgrade linux succeeded
Details
pypa.virtualenv (upgrade windows) upgrade windows succeeded
Details
pypa.virtualenv (zipapp linux) zipapp linux succeeded
Details
pypa.virtualenv (zipapp windows) zipapp windows succeeded
Details
@gaborbernat gaborbernat deleted the gaborbernat:1719 branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.