Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazonlinux support #1728

Merged
merged 2 commits into from Mar 18, 2020
Merged

amazonlinux support #1728

merged 2 commits into from Mar 18, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Mar 17, 2020

Resolves #1719.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat
Copy link
Contributor Author

gaborbernat commented Mar 17, 2020

@tzulberti can you validate that this solves your issue?

@tzulberti
Copy link

tzulberti commented Mar 17, 2020

I tested this issue by doing a git clone inside a Docker image:

FROM amazonlinux:1

RUN yum -y install python27 python27-devel python36 python36-devel python27-pip git

#RUN pip-3.6 install --upgrade virtualenv
RUN pip-3.6 install --upgrade 'setuptools>=41'
RUN pip-3.6 install --upgrade wheel
RUN git clone https://github.com/gaborbernat/virtualenv.git && \
    cd virtualenv && \
    git checkout 1719 && \
    pip-3.6 install .

RUN cd /root && virtualenv --python python2.7 /tmp/bar

RUN source /tmp/bar/bin/activate && pip freeze

And it seems to work ok

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit e76b56f into pypa:master Mar 18, 2020
37 checks passed
@gaborbernat gaborbernat deleted the 1719 branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid pip installation after creating virtualenv
2 participants