Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distlib monkeypatches #1880

Merged
merged 1 commit into from Jul 4, 2020
Merged

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jun 29, 2020

Adapt the new features added in distlib instead.

@gaborbernat gaborbernat changed the title Remove distutils monkeypatches Remove distlib monkeypatches Jun 29, 2020
@gaborbernat gaborbernat force-pushed the distutils branch 2 times, most recently from 3d4f0e5 to 14f69aa Compare Jul 4, 2020
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #1880 into master will decrease coverage by 8.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   93.97%   85.96%   -8.02%     
==========================================
  Files          86       86              
  Lines        4184     4174      -10     
==========================================
- Hits         3932     3588     -344     
- Misses        252      586     +334     
Flag Coverage Δ
#tests 85.96% <100.00%> (-8.02%) ⬇️
Impacted Files Coverage Δ
...ualenv/seed/embed/via_app_data/pip_install/base.py 98.31% <100.00%> (-0.14%) ⬇️
src/virtualenv/util/subprocess/_win_subprocess.py 0.00% <0.00%> (-95.09%) ⬇️
src/virtualenv/util/path/_pathlib/via_os_path.py 0.00% <0.00%> (-91.35%) ⬇️
...nv/create/via_global_ref/builtin/cpython/mac_os.py 24.44% <0.00%> (-59.45%) ⬇️
...ualenv/create/via_global_ref/builtin/pypy/pypy2.py 58.44% <0.00%> (-40.26%) ⬇️
src/virtualenv/util/__init__.py 83.33% <0.00%> (-16.67%) ⬇️
src/virtualenv/util/path/_pathlib/__init__.py 29.16% <0.00%> (-12.51%) ⬇️
src/virtualenv/util/subprocess/__init__.py 88.88% <0.00%> (-11.12%) ⬇️
...nv/create/via_global_ref/builtin/cpython/common.py 92.10% <0.00%> (-7.90%) ⬇️
src/virtualenv/util/path/_sync.py 86.20% <0.00%> (-6.90%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 455afbc...95d595d. Read the comment docs.

Adapt the new features added in distutils instead.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 260a26a into pypa:master Jul 4, 2020
0 of 34 checks passed
@gaborbernat gaborbernat deleted the distutils branch Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant