Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use \n instead if \r\n as line separator #1905

Merged
merged 1 commit into from Jul 24, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Jul 24, 2020

The logging framework will write to a pipe, which then will blindly transform
all carriage returns to carriage return plus line feed, when on Windows. So
injecting the \r\n leaves us with double carriage return.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #1905 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1905      +/-   ##
==========================================
- Coverage   93.98%   93.95%   -0.03%     
==========================================
  Files          86       86              
  Lines        4220     4219       -1     
==========================================
- Hits         3966     3964       -2     
- Misses        254      255       +1     
Flag Coverage Δ
#tests 93.95% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/config/ini.py 94.82% <ø> (ø)
src/virtualenv/__main__.py 100.00% <100.00%> (ø)
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012d5b5...21da8fa. Read the comment docs.

The logging framework will write to a pipe, which then will blindly transform
all carriage returns to carriage return plus line feed, when on Windows. So
injecting the \r\n leaves us with double carriage return.

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 7385e3c into pypa:master Jul 24, 2020
33 of 36 checks passed
@gaborbernat gaborbernat deleted the linesep branch Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant