Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback functionality for interpreter discovery #1995

Merged
merged 1 commit into from Oct 24, 2020

Conversation

gaborbernat
Copy link
Contributor

馃憤

@gaborbernat gaborbernat force-pushed the fallback branch 4 times, most recently from 1a2b0b9 to 8ef90e7 Compare October 24, 2020 21:46
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #1995 into main will decrease coverage by 2.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
- Coverage   94.12%   91.22%   -2.90%     
==========================================
  Files          86       86              
  Lines        4269     4274       +5     
==========================================
- Hits         4018     3899     -119     
- Misses        251      375     +124     
Flag Coverage 螖
#tests 91.22% <100.00%> (-2.90%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/virtualenv/discovery/builtin.py 85.21% <100.00%> (+0.67%) 猬嗭笍
...nv/create/via_global_ref/builtin/cpython/mac_os.py 24.30% <0.00%> (-59.67%) 猬囷笍
...nv/create/via_global_ref/builtin/cpython/common.py 93.02% <0.00%> (-6.98%) 猬囷笍
...ualenv/create/via_global_ref/builtin/pypy/pypy2.py 92.20% <0.00%> (-6.50%) 猬囷笍
...ualenv/create/via_global_ref/builtin/pypy/pypy3.py 94.87% <0.00%> (-5.13%) 猬囷笍
src/virtualenv/info.py 95.00% <0.00%> (-5.00%) 猬囷笍
src/virtualenv/util/path/_pathlib/via_os_path.py 89.62% <0.00%> (-1.89%) 猬囷笍
...rc/virtualenv/create/via_global_ref/builtin/ref.py 91.26% <0.00%> (-1.59%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 03ad839...c8c74d1. Read the comment docs.

Signed-off-by: Bern谩t G谩bor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit aac61df into pypa:main Oct 24, 2020
2 of 3 checks passed
@gaborbernat gaborbernat deleted the fallback branch October 24, 2020 23:01
pneff added a commit to pneff/virtualenv that referenced this pull request Oct 28, 2020
The previous change which introduced the fallback discovery (pypa#1995)
broke this behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant