Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --readonly-app-data option #2009

Merged
merged 1 commit into from Nov 21, 2020
Merged

Add --readonly-app-data option #2009

merged 1 commit into from Nov 21, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Nov 16, 2020

Resolves #2000

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #2009 (e4b182d) into main (271dd73) will increase coverage by 0.04%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
+ Coverage   94.32%   94.36%   +0.04%     
==========================================
  Files          86       87       +1     
  Lines        4280     4316      +36     
==========================================
+ Hits         4037     4073      +36     
  Misses        243      243              
Flag Coverage Δ
tests 94.36% <93.61%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/app_data/via_disk_folder.py 82.88% <80.00%> (-0.76%) ⬇️
src/virtualenv/app_data/read_only.py 84.21% <84.21%> (ø)
src/virtualenv/app_data/__init__.py 93.93% <92.00%> (-1.41%) ⬇️
src/virtualenv/app_data/base.py 94.11% <100.00%> (+0.24%) ⬆️
src/virtualenv/app_data/na.py 83.33% <100.00%> (+2.25%) ⬆️
src/virtualenv/app_data/via_tempdir.py 100.00% <100.00%> (+5.55%) ⬆️
src/virtualenv/run/__init__.py 95.77% <100.00%> (ø)
...virtualenv/seed/embed/via_app_data/via_app_data.py 82.17% <100.00%> (-0.18%) ⬇️
src/virtualenv/seed/wheels/bundle.py 100.00% <100.00%> (ø)
src/virtualenv/util/lock.py 99.13% <100.00%> (+0.29%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271dd73...e4b182d. Read the comment docs.

@asottile

This comment has been minimized.

@asottile

This comment has been minimized.

@asottile
Copy link
Contributor Author

I believe this is ready for review now 🎉

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite on Windows 2.7 seems to be failing. The delta coverage is 90%, can you please bring it up to 100%? Otherwise conceptually the PR looks good.

src/virtualenv/app_data/__init__.py Outdated Show resolved Hide resolved
src/virtualenv/app_data/__init__.py Outdated Show resolved Hide resolved
src/virtualenv/app_data/__init__.py Outdated Show resolved Hide resolved
src/virtualenv/app_data/base.py Outdated Show resolved Hide resolved
src/virtualenv/app_data/readonly.py Outdated Show resolved Hide resolved
src/virtualenv/app_data/via_tempdir.py Outdated Show resolved Hide resolved
src/virtualenv/run/__init__.py Outdated Show resolved Hide resolved
src/virtualenv/run/__init__.py Outdated Show resolved Hide resolved
src/virtualenv/run/__init__.py Outdated Show resolved Hide resolved
src/virtualenv/run/__init__.py Outdated Show resolved Hide resolved
@asottile
Copy link
Contributor Author

asottile commented Nov 20, 2020

here's the diff cover:

src/virtualenv/util/lock.py Outdated Show resolved Hide resolved
src/virtualenv/util/lock.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit af08309 into pypa:main Nov 21, 2020
3 of 4 checks passed
@asottile asottile deleted the readonly_app_data branch November 21, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--symlink-app-data: causes pip / wheel / setuptools to link to random tmp dir
2 participants