Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discovery on Windows and provide escape hatchet #2046

Merged
merged 1 commit into from Jan 10, 2021

Conversation

gaborbernat
Copy link
Contributor

馃憤

@gaborbernat gaborbernat changed the title add try first with for built-in discovery and prefer python core over other distributions on PEP-514 windows Improve discovery on Windows and provide escape hatchet Jan 10, 2021
@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #2046 (993134d) into main (9201a75) will decrease coverage by 0.23%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   94.27%   94.04%   -0.24%     
==========================================
  Files          87       87              
  Lines        4316     4331      +15     
==========================================
+ Hits         4069     4073       +4     
- Misses        247      258      +11     
Flag Coverage 螖
tests 94.04% <73.07%> (-0.24%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/virtualenv/discovery/builtin.py 81.45% <53.84%> (-3.77%) 猬囷笍
.../create/via_global_ref/builtin/cpython/cpython3.py 95.08% <91.66%> (-1.29%) 猬囷笍
src/virtualenv/discovery/windows/__init__.py 100.00% <100.00%> (酶)
...reate/via_global_ref/builtin/via_global_self_do.py 86.25% <0.00%> (-5.00%) 猬囷笍
...rc/virtualenv/create/via_global_ref/builtin/ref.py 92.85% <0.00%> (-0.80%) 猬囷笍
src/virtualenv/util/path/_pathlib/__init__.py 96.96% <0.00%> (+3.03%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9201a75...a3ad2ac. Read the comment docs.

鈥 other distributions on PEP-514 windows

Signed-off-by: Bern谩t G谩bor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 684a632 into pypa:main Jan 10, 2021
0 of 2 checks passed
@gaborbernat gaborbernat deleted the fixes branch January 10, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant