Integrate setuptools 0.7+ support #432

merged 3 commits into from Jun 15, 2013

2 participants

Python Packaging Authority member

Initial version of setuptools 0.7 support


cool, I'll take a look tomorrow, and also run the pip test suite using this branch of virtualenv.


lgtm. I say merge it unless there was any concerns? or any other unspoken changes you were thinking of?
and you could just delete those old options instead of leaving them commented.

I'm pretty close with a corresponding pip branch, that I could merge after.
until virtualenv-1.10 is released, the pip tox and travis files would have to point at git+

Python Packaging Authority member

OK, I'll delete the old options, leave it the rest of the day for other comments, them commit.

The only real concern I had was whether it was OK to delete options rather than leave them as do-nothing for backward compatibility (the second of the 2 commits here that fixed the .travis.yml file was needed precisely because the options had been removed). But I have a hard time imagining a case where someone would have a script that needed to work with both of virtualenv 1.9- and 1.10+, so I don't intend to worry about the issue unless someone has a better reason than "it might matter"...

@pfmoore pfmoore merged commit 86f3fd7 into pypa:develop Jun 15, 2013

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment