Update virtualenv.py #472

Merged
merged 1 commit into from Sep 21, 2015

Projects

None yet

4 participants

@pmakowski
Contributor

These lines about multiarch_exec are not valid for Mageia see for example this bug report : https://bugs.mageia.org/show_bug.cgi?id=11283

@pmakowski pmakowski Update virtualenv.py
These lines about multiarch_exec are not valid for Mageia see for example this bug report : https://bugs.mageia.org/show_bug.cgi?id=11283
bca2589
@pnasrat
Contributor
pnasrat commented Oct 8, 2013

Was the fix backported to Mageia 2, is this still relevant for Mandriva?

@dbitouze
dbitouze commented Oct 8, 2013

Was the fix backported to Mageia 2,

That seems to not be relevant for Mageia 3.

is this still relevant for Mandriva?

I'm sorry, I've no idea. Maybe Philippe Makowski could answer this.

@pnasrat
Contributor
pnasrat commented Oct 8, 2013

It is relevant as if users are still on the platform we should still apply the workaround for them.

@pmakowski
Contributor

the only thing I can say is that These lines about multiarch_exec are not valid for all actives Mageia releases (2,3 and coming 4) I can't speak for Mandriva
may be you can add a test on the distro name ?

@pmakowski
Contributor

Any news ?
please merge or change your condition

@dbitouze

The problem still occurs with virtualenv-1.11.4 shipped with Plone 4.3.3.

@pmakowski
Contributor

We apply this patch http://svnweb.mageia.org/packages/cauldron/python-virtualenv/current/SOURCES/virtualenv-1.10.1-mga-fix_inc_dir.patch?view=markup in Mageia 3,4,5 (older Mageia are no longer maintained) and for what I see in OpenMandriva, they only provide virtualenv 1.8.2 !

@dbitouze

In fact, this isn't related to Mandriva nor Mageia: virtualenv-1.11.4 shipped with Plone 4.3.3 still contains the lines:

multiarch_exec = '/usr/bin/multiarch-platform'
if is_executable_file(multiarch_exec):
    # In Mageia (2) and Mandriva distros the include dir must be like:
    # virtualenv/include/multiarch-x86_64-linux/python2.7
    # instead of being virtualenv/include/python2.7
    p = subprocess.Popen(multiarch_exec, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    stdout, stderr = p.communicate()
    # stdout.strip is needed to remove newline character
    inc_dir = join(home_dir, 'include', stdout.strip(), py_version + abiflags)
else:
    inc_dir = join(home_dir, 'include', py_version + abiflags)

as you can see with the following commands:

wget https://launchpad.net/plone/4.3/4.3.3/+download/Plone-4.3.3-UnifiedInstaller.tgz
tar xfz Plone-4.3.3-UnifiedInstaller.tgz
cd Plone-4.3.3-UnifiedInstaller/packages/
tar xfz virtualenv-1.11.4.tar.gz
more virtualenv-1.11.4/virtualenv.py | grep --after-context=10 "if is_executable_file(multiarch_exec):"
@Ivoz Ivoz merged commit 47cda29 into pypa:develop Sep 21, 2015

1 check passed

default The Travis CI build passed
Details
@Ivoz Ivoz added a commit that referenced this pull request Sep 21, 2015
@Ivoz Ivoz Add changelog for #472 4c3c613
@willingc willingc added a commit to willingc/virtualenv that referenced this pull request Oct 10, 2015
@Ivoz @willingc Ivoz + willingc Add changelog for #472 0f930dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment