Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleaned up activate.fish. #589
referenced this pull request
Apr 9, 2014
@jonathanmarvens I am indeed interested in this; the reason for the lack of merge is that currently virtualenv is left somewhat without active developers with the great depth and breadth of accumulated knowledge needed to confidently merge good changes to such an intricate project.
Currently I want expand virtualenv's tests (such as, enable it to test creating and activating envs with different shells) to mitigate the lack of that knowledge, so, e.g, I can be somewhat confident that changes merged to the fish shell script work even though I've never used fish personally.
@Ivoz Hey man, I totally understand! I can help with that if you'd like! What if I created a Vagrant VM setup specifically for testing the different aspects of virtualenv, so that folks could run that before every merge to check if all is good? Even maybe somehow integrating that with Travis if possible?