New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #93 - Tcl doesn't work inside a virtualenv on Windows #888

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
3 participants
@techtonik
Contributor

techtonik commented Apr 5, 2016

Copies:

C:\Python27\tcl\tcl8.5
C:\Python27\tcl\tk8.5
C:\Python35\tcl\tcl8.6
C:\Python35\tcl\tk8.6

Checked that Python 3.4 contains the same dirs as 3.5.

@Ivoz Ivoz merged commit cb368e9 into pypa:develop Apr 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Ivoz added a commit that referenced this pull request Apr 14, 2016

@techtonik techtonik deleted the techtonik:tcltk branch Apr 15, 2016

@yan12125

This comment has been minimized.

Show comment
Hide comment
@yan12125

yan12125 May 29, 2016

Contributor

Python 3.3.5 still ships with Tcl 8.5, so the Python 3.3 build on Windows failed. [1] From CPython's log, Tcl 8.6.1 was introduced in Python 3.4.0 [2] But anyway I think relying on CPython version is fragile.

[1] https://ci.appveyor.com/project/yan12125/virtualenv/build/job/9h8crh9s4k7ag6pb
[2] https://hg.python.org/cpython/rev/730d89d66b38

Contributor

yan12125 commented May 29, 2016

Python 3.3.5 still ships with Tcl 8.5, so the Python 3.3 build on Windows failed. [1] From CPython's log, Tcl 8.6.1 was introduced in Python 3.4.0 [2] But anyway I think relying on CPython version is fragile.

[1] https://ci.appveyor.com/project/yan12125/virtualenv/build/job/9h8crh9s4k7ag6pb
[2] https://hg.python.org/cpython/rev/730d89d66b38

techtonik added a commit to techtonik/virtualenv that referenced this pull request May 29, 2016

@techtonik techtonik referenced this pull request May 29, 2016

Closed

Fix Tcl for Python 3.3- #926

@techtonik

This comment has been minimized.

Show comment
Hide comment
@techtonik

techtonik May 29, 2016

Contributor

@yan12125 I don't have time to test it - edited on GitHub, so can you take a look if it at least doesn't break anything?

Contributor

techtonik commented May 29, 2016

@yan12125 I don't have time to test it - edited on GitHub, so can you take a look if it at least doesn't break anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment