Fix issue #93 - Tcl doesn't work inside a virtualenv on Windows #888

Merged
merged 1 commit into from Apr 14, 2016

Projects

None yet

3 participants

@techtonik
Contributor

Copies:

C:\Python27\tcl\tcl8.5
C:\Python27\tcl\tk8.5
C:\Python35\tcl\tcl8.6
C:\Python35\tcl\tk8.6

Checked that Python 3.4 contains the same dirs as 3.5.

@Ivoz Ivoz merged commit cb368e9 into pypa:develop Apr 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ivoz Ivoz added a commit that referenced this pull request Apr 14, 2016
@Ivoz Ivoz Add changelog for #888 5885665
@techtonik techtonik deleted the techtonik:tcltk branch Apr 15, 2016
@yan12125
Contributor

Python 3.3.5 still ships with Tcl 8.5, so the Python 3.3 build on Windows failed. [1] From CPython's log, Tcl 8.6.1 was introduced in Python 3.4.0 [2] But anyway I think relying on CPython version is fragile.

[1] https://ci.appveyor.com/project/yan12125/virtualenv/build/job/9h8crh9s4k7ag6pb
[2] https://hg.python.org/cpython/rev/730d89d66b38

@techtonik techtonik added a commit to techtonik/virtualenv that referenced this pull request May 29, 2016
@techtonik techtonik Fix Tcl for Python 3.3- ce106d6
@techtonik techtonik referenced this pull request May 29, 2016
Closed

Fix Tcl for Python 3.3- #926

@techtonik
Contributor

@yan12125 I don't have time to test it - edited on GitHub, so can you take a look if it at least doesn't break anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment