Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Always store _OLD_VIRTUAL_PATH in a sh compat format #904
If in a subshell from within
This patch makes activate.fish always store the old path using
There you will see the
This was migrated from #827 to reparent it to the
referenced this pull request
Jan 5, 2017
https://dev.azure.com/pypa/virtualenv/_build/results?buildId=3174 note you'll need it to pass
There's a bug at the moment which causes shell tests not available to be silently skipped in CI. I'll need to fix this tomorrow, but this could bring up some platform incompatibilities, and we probably need to provision fish for the CI. Only after if tests pass we're done. Leave it with me for now, unless you want to add fish provisioning into the CI.
Ah. I thought that might need to be added somewhere.
FWIW, it passes for me locally because I have fish installed. I'm not sure where to add it to your build configuration since I've never worked with Azure. If you let me know where to make the change, I'm happy to do that. Otherwise I can leave it to you.
Thanks for the feedback!