New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send confirmation link in email on new account registration #2065

Closed
nezhar opened this Issue May 31, 2017 · 4 comments

Comments

Projects
7 participants
@nezhar

nezhar commented May 31, 2017

I just wrote my first package that I wanted to publish on PyPI and didn't have an account. I have registered yesterday through the new registration form: https://pypi.org/account/register/.

The registration process had no issues, the account was directly active and the log in worked. Today I prepared the package for upload but i received a 401 error:
Upload failed (401): You must be identified to edit package information

After some research, I saw also other people complaining, and this might happen if the activation link in the email is not clicked. So one problem might be that the activation email is not being sent and the account is directly active.

Since I don't found any way resending an activation link, and the login with the account worked normally I have deleted the account and made another registration using the old PyPI website: https://pypi.python.org/pypi?%3Aaction=register_form

This time I received an activation link, which led me to a page where I also had to accept the submission terms. So probably this part is missing and this is why the authorization failed with the other account.

@dstufft dstufft added this to the 1: Launch: redirect pypi.python.org to pypi.io milestone Jul 1, 2017

@svenevs

This comment has been minimized.

Show comment
Hide comment
@svenevs

svenevs Sep 13, 2017

Hello, I think the same fix needs to happen for test pypi. The guide asks you to register with a link to https://test.pypi.org/account/register/. I was getting some 401 responses as well, and then found this issue. Using the linked site, I never received a confirmation e-mail.

Edit: see comment below and try that first. I suspect my "solution" is invalid, since I was able to "register" but still cannot upload.

Solution: I went to https://testpypi.python.org/pypi (where the difference is a .python after testpypi), deleted the account I just made, and re-registered using this site (so following the link to https://testpypi.python.org/pypi?%3Aaction=register_form) and saw both a terms agreement as well as received a confirmation e-mail letting me finish the registration.

I believe the https://github.com/pypa/python-packaging-user-guide repo is the source code, would a PR fixing the testpypi URL be helpful or is the problem more complicated?

I still can't seem to find the right URL to use though. It's either these issues or using what I think the right URL should be:

Uploading distributions to https://test.pypi.io/legacy
Uploading exhale-0.1.2.tar.gz
RedirectDetected: "https://test.pypi.io/legacy" attempted to redirect to "https://test.pypi.org/legacy" during upload. Aborting...

redirect to itself fails?

svenevs commented Sep 13, 2017

Hello, I think the same fix needs to happen for test pypi. The guide asks you to register with a link to https://test.pypi.org/account/register/. I was getting some 401 responses as well, and then found this issue. Using the linked site, I never received a confirmation e-mail.

Edit: see comment below and try that first. I suspect my "solution" is invalid, since I was able to "register" but still cannot upload.

Solution: I went to https://testpypi.python.org/pypi (where the difference is a .python after testpypi), deleted the account I just made, and re-registered using this site (so following the link to https://testpypi.python.org/pypi?%3Aaction=register_form) and saw both a terms agreement as well as received a confirmation e-mail letting me finish the registration.

I believe the https://github.com/pypa/python-packaging-user-guide repo is the source code, would a PR fixing the testpypi URL be helpful or is the problem more complicated?

I still can't seem to find the right URL to use though. It's either these issues or using what I think the right URL should be:

Uploading distributions to https://test.pypi.io/legacy
Uploading exhale-0.1.2.tar.gz
RedirectDetected: "https://test.pypi.io/legacy" attempted to redirect to "https://test.pypi.org/legacy" during upload. Aborting...

redirect to itself fails?

@jonemo

This comment has been minimized.

Show comment
Hide comment
@jonemo

jonemo Sep 15, 2017

Contributor

I can confirm the reported behavior. I just recently wrote up my learnings from publishing a package to PyPI for the first time (link to my blog post) and found that

  • The registration form on test.pypi.org seems to work
  • ... but the confirmation email never arrives and there is no indication to the user that one should arrive
  • ... therefore users never get to see the terms and cannot activate their account
  • ... and then get a confusing error message when attempting to upload a package

The workaround is to use the registration form on pypi.python.org/pypi, but then complete all other steps on pypi.org.

@svenevs: This is my .pypirc with URLs for Test PyPI and real PyPI that worked for me:

 #~/.pypirc
    
 [distutils]
 index-servers =
   pypi
   pypitest
    
 [pypi]
 repository: https://pypi.org/legacy/
 username: YOUR_USERNAME_GOES_HERE
    
 [pypitest]
 repository: https://test.pypi.org/legacy/
 username: YOUR_USERNAME_GOES_HERE
Contributor

jonemo commented Sep 15, 2017

I can confirm the reported behavior. I just recently wrote up my learnings from publishing a package to PyPI for the first time (link to my blog post) and found that

  • The registration form on test.pypi.org seems to work
  • ... but the confirmation email never arrives and there is no indication to the user that one should arrive
  • ... therefore users never get to see the terms and cannot activate their account
  • ... and then get a confusing error message when attempting to upload a package

The workaround is to use the registration form on pypi.python.org/pypi, but then complete all other steps on pypi.org.

@svenevs: This is my .pypirc with URLs for Test PyPI and real PyPI that worked for me:

 #~/.pypirc
    
 [distutils]
 index-servers =
   pypi
   pypitest
    
 [pypi]
 repository: https://pypi.org/legacy/
 username: YOUR_USERNAME_GOES_HERE
    
 [pypitest]
 repository: https://test.pypi.org/legacy/
 username: YOUR_USERNAME_GOES_HERE
@svenevs

This comment has been minimized.

Show comment
Hide comment
@svenevs

svenevs Sep 15, 2017

The workaround is to use the registration form on pypi.python.org/pypi, but then complete all other steps on pypi.org.

Interesting. It doesn't work for me, I was already registered on "real" pypi before getting the e-mail from the way I went about it (delete, alternative url). As such, the URL you have gives me 403 errors :S Hopefully your fix will apply to most situations. I think I pigeonholed myself somehow.

svenevs commented Sep 15, 2017

The workaround is to use the registration form on pypi.python.org/pypi, but then complete all other steps on pypi.org.

Interesting. It doesn't work for me, I was already registered on "real" pypi before getting the e-mail from the way I went about it (delete, alternative url). As such, the URL you have gives me 403 errors :S Hopefully your fix will apply to most situations. I think I pigeonholed myself somehow.

@di di changed the title from Account registration incomplete to Send confirmation link in email on new account registration Dec 5, 2017

@di di added legacy parity and removed requires triaging labels Dec 7, 2017

@di di removed the legacy parity label Feb 7, 2018

@brainwane brainwane added this to Next milestone in Warehouse rollout Feb 12, 2018

@di di moved this from Milestone 2: End User MVP to In Progress in Warehouse rollout Feb 14, 2018

@di di self-assigned this Feb 14, 2018

@di

This comment has been minimized.

Show comment
Hide comment
@di

di Feb 14, 2018

Member

Branch for this is here: https://github.com/pypa/warehouse/tree/verify-email-on-registration, blocked on merging #2898.

Member

di commented Feb 14, 2018

Branch for this is here: https://github.com/pypa/warehouse/tree/verify-email-on-registration, blocked on merging #2898.

@di di closed this in #2960 Feb 16, 2018

Warehouse rollout automation moved this from In Progress to Done Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment