Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage projects mobile ui #2865

Merged
merged 5 commits into from Jan 31, 2018
Merged

Manage projects mobile ui #2865

merged 5 commits into from Jan 31, 2018

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Jan 31, 2018

Collaborators

screenshot from 2018-01-31 08-00-14
screenshot from 2018-01-31 08-00-04
screenshot from 2018-01-31 07-59-57

Releases

screenshot from 2018-01-31 08-02-56
screenshot from 2018-01-31 08-02-40
screenshot from 2018-01-31 08-02-25

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

TODO before we can merge this PR

  • Make buttons line up
  • Make manager 'projects' page better on mobile

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

Manager projects on mobile

screenshot from 2018-01-31 19-57-58

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

Button alignment (Chrome, FF):
screenshot from 2018-01-31 20-05-39
screenshot from 2018-01-31 20-05-27

@nlhkabu nlhkabu requested a review from di January 31, 2018 20:06
@nlhkabu nlhkabu changed the title WIP: Manage projects mobile ui Manage projects mobile ui Jan 31, 2018
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

hi @di, this is ready to go on my side. Please test each of the manage projects pages on mobile (or equivalent resolution) to confirm. Thanks

@di
Copy link
Member

di commented Jan 31, 2018

@nlhkabu The search box is a little confusing in the mobile UI, especially on a page which lists the user's projects:

warehouse local_manage_projects_ nexus 5x

Do you think it makes sense to hide it on mobile when the user is in the logged-in section of the site? I don't think this should be a blocker for this PR but maybe something to consider in the future.

@nlhkabu nlhkabu merged commit 609a58c into master Jan 31, 2018
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

🎉 🎉 🎉 🎉 🎉

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jan 31, 2018

Thanks @di. I've opened #2868 to address your concern. I agree that we should remove it here :) I'll make a separate PR

@di di deleted the manage-projects-mobile-ui branch January 31, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants