Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd and re-prioritize icons in url_icon #5273
Conversation
ewdurbin
reviewed
Jan 10, 2019
ewdurbin
approved these changes
Jan 10, 2019
ewdurbin
merged commit 8d1710f
into
pypa:master
Jan 10, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Thanks @kernc! |
This comment has been minimized.
This comment has been minimized.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kernc commentedJan 10, 2019
•
edited
This PR adds some new URL icons for project URLs:
fa-bugfor issue tracker,fa-coinsfa-donatefor donations link.The trigger strings are those recommended in specs for
project_urls(PEP-459, pypa/sampleproject/setup.py).Additionally, homepage (
fa-home) and documentation (fa-book) icons are reordered so that they are preferred over more generic service (e.g. GitHub) icons.