From d29c8a6787aef97e3b7957fd1eeb3a4f518085cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20Gr=C3=B6nholm?= Date: Sat, 5 Aug 2023 16:21:06 +0300 Subject: [PATCH] Don't wrap version specifiers in parens in Requires-Dist Fixes #551. --- docs/news.rst | 1 + src/wheel/metadata.py | 2 +- tests/test_metadata.py | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/news.rst b/docs/news.rst index a76eb6cd..df991f2d 100644 --- a/docs/news.rst +++ b/docs/news.rst @@ -5,6 +5,7 @@ Release Notes - Fixed naming of the ``data_dir`` directory in the presence of local version segment given via ``egg_info.tag_build`` (PR by Anderson Bravalheri) +- Fixed version specifiers in ``Requires-Dist`` being wrapped in parentheses **0.41.0 (2023-07-22)** diff --git a/src/wheel/metadata.py b/src/wheel/metadata.py index b391c962..ddcb90e7 100644 --- a/src/wheel/metadata.py +++ b/src/wheel/metadata.py @@ -92,7 +92,7 @@ def requires_to_requires_dist(requirement: Requirement) -> str: requires_dist.append(spec.operator + spec.version) if requires_dist: - return " (" + ",".join(sorted(requires_dist)) + ")" + return " " + ",".join(sorted(requires_dist)) else: return "" diff --git a/tests/test_metadata.py b/tests/test_metadata.py index e267f023..84807326 100644 --- a/tests/test_metadata.py +++ b/tests/test_metadata.py @@ -22,11 +22,11 @@ def test_pkginfo_to_metadata(tmp_path): ("Provides-Extra", "faster-signatures"), ("Requires-Dist", "ed25519ll ; extra == 'faster-signatures'"), ("Provides-Extra", "rest"), - ("Requires-Dist", "docutils (>=0.8) ; extra == 'rest'"), + ("Requires-Dist", "docutils >=0.8 ; extra == 'rest'"), ("Requires-Dist", "keyring ; extra == 'signatures'"), ("Requires-Dist", "keyrings.alt ; extra == 'signatures'"), ("Provides-Extra", "test"), - ("Requires-Dist", "pytest (>=3.0.0) ; extra == 'test'"), + ("Requires-Dist", "pytest >=3.0.0 ; extra == 'test'"), ("Requires-Dist", "pytest-cov ; extra == 'test'"), ]