Skip to content

Fix encoding warnings #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix encoding warnings #92

merged 1 commit into from
Feb 18, 2025

Conversation

@AA-Turner
Copy link
Contributor

@AA-Turner AA-Turner commented Feb 17, 2025

Explicitly specify encoding and run tests with -X warn_default_encoding / PYTHONWARNDEFAULTENCODING set. In most cases we just replace read_text with read_bytes as model_validate_json() can take bytes.

A

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

woodruffw
woodruffw approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated!

@woodruffw woodruffw merged commit 668ac9e into pypi:main Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner @CLAassistant @woodruffw