Skip to content

Commit 45fe4d0

Browse files
authored
test: replace pretend usages in secrets tests (#20241)
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
1 parent f0fb84d commit 45fe4d0

7 files changed

Lines changed: 420 additions & 545 deletions

File tree

tests/conftest.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,6 @@ def __call__(self, *args, **kwargs):
103103
def calls(self):
104104
return [pretend.call(*c.args, **c.kwargs) for c in self._mock.call_args_list]
105105

106-
@calls.setter
107-
def calls(self, value):
108-
# Support the legacy ``recorder.calls = []`` reset idiom.
109-
assert value == [], "metrics recorder shim only supports resetting to []"
110-
self._mock.reset_mock()
111-
112106
def __getattr__(self, name):
113107
return getattr(self._mock, name)
114108

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,22 @@
11
# SPDX-License-Identifier: Apache-2.0
22

3-
import pretend
4-
53
from warehouse.integrations.secrets import tasks, utils
64

75

8-
def test_analyze_disclosure_task(monkeypatch, someorigin):
9-
analyze_disclosure = pretend.call_recorder(lambda *a, **k: None)
10-
monkeypatch.setattr(utils, "analyze_disclosure", analyze_disclosure)
6+
def test_analyze_disclosure_task(mocker, someorigin):
7+
analyze_disclosure = mocker.patch.object(utils, "analyze_disclosure", autospec=True)
118

12-
request = pretend.stub()
13-
disclosure_record = pretend.stub()
9+
request = mocker.sentinel.request
10+
disclosure_record = mocker.sentinel.disclosure_record
1411

1512
tasks.analyze_disclosure_task(
1613
request=request,
1714
disclosure_record=disclosure_record,
1815
origin=someorigin.to_dict(),
1916
)
2017

21-
assert analyze_disclosure.calls == [
22-
pretend.call(
23-
request=request,
24-
disclosure_record=disclosure_record,
25-
origin=someorigin,
26-
)
27-
]
18+
analyze_disclosure.assert_called_once_with(
19+
request=request,
20+
disclosure_record=disclosure_record,
21+
origin=someorigin,
22+
)

0 commit comments

Comments
 (0)