Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ie8 #979

Closed
3 tasks
nlhkabu opened this issue Feb 20, 2016 · 5 comments
Closed
3 tasks

Support ie8 #979

nlhkabu opened this issue Feb 20, 2016 · 5 comments
Labels
HTML requires change to HTML files javascript requires change to JavaScript files UX/UI design, user experience, user interface

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Feb 20, 2016

At the moment ie8 is totally broken. I don't want to spend a heap of time making it perfect, but I would like it to be functional.

As far as I can tell, these are the primary issues:

  • HTML5 tags not rendering (look at fix with modernizr)
  • SVGs do not display (provide png fallback)
  • JS not working (I don't know what the solution is for this - will need to debug)
@nlhkabu nlhkabu added UX/UI design, user experience, user interface javascript requires change to JavaScript files HTML requires change to HTML files labels Feb 20, 2016
@nlhkabu nlhkabu added this to the Become PyPI milestone Feb 20, 2016
@agronholm
Copy link

I mean no disrespect, but IE < 11 has been EOL'd beginning Jan 12th 2016. So why go through this effort when its vendor will not even supply security patches anymore?

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Feb 20, 2016

Because we still have almost 5000 users per month on ie8 (primarily in China). I expect this will decline, but it still a large enough number to justify spending a couple of hours debugging.

@di
Copy link
Member

di commented Feb 22, 2016

JS is not working because jQuery 2.x only supports IE 9+: http://jquery.com/browser-support/

@dstufft
Copy link
Member

dstufft commented Mar 3, 2016

Given that jQuery doesn't work on IE8 nor does l20n.js does it make sense to try and support this still? We're using jQuery to do a "client side include" of content like the login/logout/current-user indicator on each page so that the main content can be cached once for all users, but that additional content can be added post-cache. So unless we come up with a IE8 compliant solution to that, they're not going to be able to access any logged in areas of Warehouse.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 6, 2016

Ok, given this complexity, let's drop this for now and respond should we have any significant negative community feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTML requires change to HTML files javascript requires change to JavaScript files UX/UI design, user experience, user interface
Projects
None yet
Development

No branches or pull requests

4 participants