Permalink
Commits on Sep 21, 2018
  1. Fix the url to show <#foo>-tab

    farhaanbukhsh authored and pypingou committed Sep 11, 2018
    This commit adds the ability to switch tabs with the right
    url link on settings page.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Jul 31, 2018
  1. Add the build step to web run script

    farhaanbukhsh authored and pypingou committed Jul 28, 2018
    This commit adds the build step to the web run script of
    docker file, this enables to resolve few dependecy problem
    and have a setup in the container.
    
    Merges https://pagure.io/pagure/pull-request/3466
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Jul 24, 2018
  1. Fix #3431: Text entry on diff of a file

    farhaanbukhsh committed Jul 24, 2018
    This commit diables the adding of comment totally if the user
    is not logged in and authenticated.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Apr 12, 2018
  1. Add test for repo user access

    farhaanbukhsh committed Apr 3, 2018
    This commit add test for adding user to a private repo and check if the user can access
    the private repo.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
  2. Fix private repo to be accessed by ACLs other than admin

    farhaanbukhsh committed Mar 7, 2018
    This commit fixes the permission issues to display private project on the UI when the user is added as commiter or ticker access.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Mar 6, 2018
  1. Add Tests and exception for non-unicode password

    farhaanbukhsh authored and pypingou committed Mar 28, 2017
    This commit introduces raising ``ValueError`` exception if the password
    is not unicoded. And the tests for the same are included.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
    
    Merges https://pagure.io/pagure/pull-request/2014
    
    Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
  2. Organize test for non-ascii password

    farhaanbukhsh authored and pypingou committed Mar 21, 2017
    As pointed out by ``@jcline`` a separate test is provided for using non-ascii
    password for user creating a user and logging in pagure.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Mar 5, 2018
  1. Fix unicode in password and add test

    farhaanbukhsh authored and pypingou committed Mar 18, 2017
    After a long discussion with ``@jcline`` and as he pointed out that using
    ``to_unincode`` is a really bad option for storing password since after
    unicoding some non-ascii value it starts giving the same character. This could
    be really harmful for security reasons.
    
    The tests are provided to check the same that things don't break on entering
    any non-ascii characters.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
  2. Fix UnicodeEncode on entering non-ascii password

    farhaanbukhsh authored and pypingou committed Mar 1, 2017
    The above changes encode the password to ``UTF_8`` to make the password
    compatible for ascii as well as non-ascii character.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Mar 2, 2018
  1. Replace print with debug logs

    farhaanbukhsh committed Mar 1, 2018
    The print statements are not read by docker logs instead using debug statements are better this way the dev server could see the logs and docker logs could them too.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
  2. Improve docker-compose and documentation

    farhaanbukhsh committed Mar 1, 2018
    This commits makes the current docker-compose.yml to work with the latest version of docker-compose, documentation on creating the initial directories are added to the docker-compose section.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
Commits on Apr 14, 2017
  1. Fix tests after rebase

    farhaanbukhsh authored and pypingou committed Apr 12, 2017
    Change in the ``project`` api and few changes in `lib.git``
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
    
    Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
  2. Fix pep8 convention and chages suggested by ``@Pingou``

    farhaanbukhsh authored and pypingou committed Apr 4, 2017
    This commit few pep8 changes and changing ``lib/git.py`` to use
    ``_get_project`` instead of ``get_authorized_project``
    
    Certain formatting changes have also been resolved
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
  3. Fix tests and migrated to ``_getrepo``

    farhaanbukhsh authored and pypingou committed Apr 3, 2017
    The ``issue`` api changed its architecture to use a different way of getting
    the repo. The refactoring is amazing since now only one function is required to
    make a get repo call.
    
    This commit also fixes few test cases and modified the test json for the same.
    The alembic revision file is updated with the new revision.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
  4. Fix test cases and replace get_project after acl

    farhaanbukhsh authored and pypingou committed Mar 19, 2017
    This commit fix various test case failing after recent rebase and merging of
    acl, the test for private repo has also been updated with new issue structure.
    
    Signed-off-by: Farhaan Bukhsh <farhaan.bukhsh@gmail.com>
  5. Fix the check for project=None

    farhaanbukhsh authored and pypingou committed Feb 12, 2017
  6. Refactor code to have lesser check for sending notification

    farhaanbukhsh authored and pypingou committed Feb 12, 2017
    The check for the project being private or not is moved to lib.notify
    so that there will be less code in lib/__init__.py
  7. Fix test for private repo

    farhaanbukhsh authored and pypingou committed Feb 12, 2017
  8. Fix test after rebase

    farhaanbukhsh authored and pypingou committed Feb 5, 2017
  9. Fix 80 character pep8 convention

    farhaanbukhsh authored and pypingou committed Jan 23, 2017
  10. Fix tests

    farhaanbukhsh authored and pypingou committed Jan 18, 2017
  11. Document code and fix condition to filter

    farhaanbukhsh authored and pypingou committed Jan 14, 2017
    Code documentation is done as pointed by @Pingou and @jcline
    
    The condition private == username is removed because there was no need to filter,
    the filtering needs to be done when a different user is viewing the projects.
  12. Fix alembic version

    farhaanbukhsh authored and pypingou committed Jan 13, 2017
  13. Fix tests after rebase

    farhaanbukhsh authored and pypingou committed Jan 13, 2017