Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload test requires pypirc to avoid password prompt #141

Merged
merged 1 commit into from
May 19, 2016

Conversation

dpkp
Copy link
Contributor

@dpkp dpkp commented May 15, 2016

@mplanchard
Copy link
Contributor

I'm not sure supplying a default password is the right way to solve this. I started looking into this last week, but haven't found the source of the issue. The test that is hanging should not be requesting a password, as it's set to drop all auth.

@dpkp
Copy link
Contributor Author

dpkp commented May 15, 2016

It was caused by a change in setuptools. See:

https://github.com/pypa/setuptools/blob/master/CHANGES.rst#v20100
pypa/setuptools#555

@dpkp
Copy link
Contributor Author

dpkp commented May 15, 2016

I updated the username and password to be empty strings, which I believe is what you're attempting to test (no password required).

The other "fix" would be to attempt to set an older setuptools version in your tox deps configuration.

@mplanchard
Copy link
Contributor

Awesome. I thought it might be something in setuptools, but I have been quite busy and unable to look into in depth yet. Thanks for figuring it out! I'll try to get this reviewed sometime today, along with your other PRs.

@mplanchard
Copy link
Contributor

Looks good. Merging.

@mplanchard mplanchard merged commit d083266 into pypiserver:master May 19, 2016
@ankostis ankostis modified the milestone: Next 1.2.x Release Jun 17, 2016
@ankostis
Copy link
Member

Thanks @dpkp for this fix, you really nailed it!

michaelkuty pushed a commit to michaelkuty/pypiserver that referenced this pull request Jun 27, 2016
upload test requires pypirc to avoid password prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants