Use a constant copyright date #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because a) copyright only expires 70 years after the death of the author and b) users might look at this string to see how current this software is but this will be misleading when it is rebuilt later. and c) for reproducible builds we want to be able to rebuild packages later and still get bit-identical output. In this case, it produced diffs in /usr/share/doc/packages/python36-PyQRCode/html/_modules/pyqrcodeng.html - <p>© Copyright 2013-2021, Michael Nooner, 2018 - 2021 Lars Heuer.</p> + <p>© Copyright 2013-2021, Michael Nooner, 2018 - 2037 Lars Heuer.</p> This patch was done while working on reproducible builds for openSUSE.
|
You are probably right and I support the change. But I no longer have write access to this project and it is unmaintained, see #16 Unless it has already been added to openSUSE, I would refrain from doing so. |
|
https://code.opensuse.org/package/python-PyQRCode/tree/master looks like we moved to NG two weeks ago. Matej Cepl seems to have done that switch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use a constant copyright date
because a) copyright only expires 70 years after the death of the author
and b) users might look at this string to see how current this software is
but this will be misleading when it is rebuilt later.
and c) for reproducible builds we want to be able to rebuild packages later
and still get bit-identical output. In this case, it produced diffs in
This PR was done while working on reproducible builds for openSUSE.