Fix `cleanup` when the running qt application is not a QApplication #408

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

3 participants

@ales-erjavec
Contributor

Fix a segmentation fault in atexit registered cleanup function (in QGraphicsScene constructor) when the running qt application is not a fully fledged QApplication but a QCoreApplication (or possibly QGuiApplication on PyQt5).

@ales-erjavec ales-erjavec Fix `cleanup` when the running qt application is not a QApplication
c4c31c3
@codecov-io

Current coverage is 34.09% (diff: 100%)

Merging #408 into develop will increase coverage by 0.04%

@@            develop       #408   diff @@
==========================================
  Files           198        198          
  Lines         27249      27250     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       4568       4568          
==========================================
+ Hits           9280       9292    +12   
+ Misses        17143      17114    -29   
- Partials        826        844    +18   

Powered by Codecov. Last update 4cdc3ac...c4c31c3

@campagnola
Contributor

Looks good to me. Thanks!

@campagnola campagnola merged commit fe90f46 into pyqtgraph:develop Dec 14, 2016

3 checks passed

codecov/patch 100% of diff hit (target 34.05%)
Details
codecov/project 34.09% (+0.04%) compared to 4cdc3ac
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment