Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve consumer #54

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@mpenet
Copy link
Contributor

commented Oct 4, 2019

  • make the consumer-driver ConsumerRecords decoding configurable. It is done from second arg that is now a map with potentially :kinsky.client/consumer-decoder-fn key present, defaulting to kinsky.client/consumer-records->data (backward compat)

  • add helpers to shape ConsumerRecords from that new option
    simplify consumer-records->data

  • modify kinsky.client/consumer to support this new options: consumer map can now include the extra drivers options keys and will remove them before passing the "rest" to the underlying kafka KafkaConsumer.

Copy link

left a comment

Drive-by comment since I don't feel I know the code enough yet to review it properly. I will look at the rest of the code however.

src/kinsky/client.clj Outdated Show resolved Hide resolved
@mpenet mpenet force-pushed the mpenet:feature/improve-consumer branch from c8e68f1 to c65c0a7 Oct 4, 2019
@pyr
pyr approved these changes Oct 4, 2019
src/kinsky/client.clj Show resolved Hide resolved
@pyr pyr merged commit 2871b9a into pyr:master Oct 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.