New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit charset in json content type header #13

Merged
merged 1 commit into from Oct 30, 2017

Conversation

2 participants
@davidbgk
Contributor

davidbgk commented Oct 27, 2017

@davidbgk davidbgk requested a review from yohanboniface Oct 27, 2017

@yohanboniface yohanboniface merged commit ad29ea3 into master Oct 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yohanboniface yohanboniface deleted the json-charset branch Oct 30, 2017

@yohanboniface

This comment has been minimized.

Member

yohanboniface commented on 4eec9f2 Nov 28, 2017

On the fly, from https://www.techempower.com/benchmarks/#section=code

The response content type must be set to application/json. Note that specifying the character encoding is unnecessary for this content type.

With a link to http://www.ietf.org/rfc/rfc7159.txt

The default encoding is UTF-8

Also https://tools.ietf.org/html/rfc4627

So I wonder if we should really add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment