New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Query instanciation lazy #35

Merged
merged 1 commit into from Nov 30, 2017

Conversation

2 participants
@yohanboniface
Member

yohanboniface commented Nov 28, 2017

It's about 4000 req/s on the benchmark when it does not access request.query, and there is no impact when it does.

@yohanboniface yohanboniface requested a review from davidbgk Nov 28, 2017

def __init__(self):
def __init__(self, app):
self.app = app

This comment has been minimized.

@yohanboniface

yohanboniface Nov 28, 2017

Member

This allows to keep Query reference on Roll.
Other option is to have Query on Request itself, but that means overriding Request AND Query when we'd only need to override Query.

@davidbgk

Breaking change in changelog? 🙃

@yohanboniface yohanboniface merged commit 4b387f8 into master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yohanboniface yohanboniface deleted the lazy-query branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment