New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call request hook even if request.path is not found #45

Merged
merged 1 commit into from Jan 5, 2018

Conversation

2 participants
@yohanboniface
Member

yohanboniface commented Jan 5, 2018

fix #44

@yohanboniface yohanboniface requested a review from davidbgk Jan 5, 2018

@@ -381,16 +381,6 @@ def write(self, *args):
self.writer.close()
class Routes(BaseRoutes):

This comment has been minimized.

@davidbgk

davidbgk Jan 5, 2018

Contributor

🎆

if not request.route.payload:
response.status = 400
response.body = b'Really this is a bad request'
return True # Shortcut the response process.

This comment has been minimized.

@davidbgk

davidbgk Jan 5, 2018

Contributor

Typo: Shortcuts

@yohanboniface yohanboniface merged commit 57623ed into master Jan 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yohanboniface yohanboniface deleted the request-hook-404 branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment