Extending PR #25 #36
Merged
Extending PR #25 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it so that pyreadline can only be imported on Windows. This saves people from wasting time trying to use it on different platforms only to get weird results or crashes.
Adding platform check to setup.py Moving platform check in __init__.py as early as possible
This was referenced Jul 14, 2015
turky
pushed a commit
to turky/pyreadline
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend PR#25 by adding platform check in setup.py and moving check as early as possible in init.py.
This PR fixes issue #13.