New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in initial trace setter in HMC #1675

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@neerajprad
Copy link
Collaborator

neerajprad commented Dec 18, 2018

  • Fixes a bug in HMC initial trace setting loop. We didn't hit upon this bug because none of our tests / examples gave an initial trace with NaN/Inf values and hence this wasn't tested. Added a small test by mocking the log prob computation so that this code path is exercised.
  • Also, fixes an issue with multiprocessing so that the rng seed is restricted to the interval [0, 2**32-1] which is required in numpy.

neerajprad added some commits Dec 18, 2018

@jpchen

jpchen approved these changes Dec 18, 2018

@fehiepsi
Copy link
Collaborator

fehiepsi left a comment

LGTM!

@eb8680 eb8680 merged commit 1f4f3d5 into pyro-ppl:dev Dec 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment