Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ReduceLROnPlateau scheduler #1910

Merged
merged 4 commits into from Jun 15, 2019

Conversation

Projects
None yet
3 participants
@jpchen
Copy link
Member

commented Jun 11, 2019

This PR:

  1. changes the scheduler interface to be more similar to PyTorch's (and changes the order of the calls as per 1.1)
  2. supports the remaining schedulers (esp ReduceLROnPlateau which has been requested)

there are still some outstanding bugs that are being fixed on the pytorch end.

Tested:

  • schedulers that have different interfaces
  • fixed and variable epochs
Show resolved Hide resolved pyro/optim/lr_scheduler.py Outdated
Show resolved Hide resolved pyro/optim/optim.py
i
Show resolved Hide resolved tests/optim/test_optim.py Outdated
Show resolved Hide resolved pyro/optim/optim.py
@fritzo

fritzo approved these changes Jun 15, 2019

@fritzo fritzo merged commit 76b8278 into dev Jun 15, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.