New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized variable $time in files/files_front controller #2961

Closed
pavoltanuska opened this Issue Sep 5, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@pavoltanuska

pavoltanuska commented Sep 5, 2013

Link to file:
https://github.com/pyrocms/pyrocms/blob/2.3/develop/system/cms/modules/files/controllers/files_front.php

Line: 203

In case file (image) already exists script returns code 304 but with uninitialized "Last-Modified" time.

This script was OK in version 2.1

https://github.com/pyrocms/pyrocms/blob/2.1/develop/system/cms/modules/files/controllers/files_front.php
Line: 216

Affected versions (I checked): 2.2+

Proposed solution:
Change variable $time on line 203 to $thumb_modified (edit: thumb, not humb...)

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Sep 12, 2013

Member

Can you send us a PR please?

Member

philsturgeon commented Sep 12, 2013

Can you send us a PR please?

@pavoltanuska

This comment has been minimized.

Show comment
Hide comment
@pavoltanuska

pavoltanuska Sep 17, 2013

Oh, that looks bad. At first I didn't know that git message strips "$", then I tried to amend last commit but there was merge conflict which created another commit.
Then I deleted whole branch and created new, commited there and felt proud how clean I solved everything...

pavoltanuska commented Sep 17, 2013

Oh, that looks bad. At first I didn't know that git message strips "$", then I tried to amend last commit but there was merge conflict which created another commit.
Then I deleted whole branch and created new, commited there and felt proud how clean I solved everything...

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Sep 17, 2013

Member

Did you get one final PR done?

Member

philsturgeon commented Sep 17, 2013

Did you get one final PR done?

@pavoltanuska

This comment has been minimized.

Show comment
Hide comment
@pavoltanuska

pavoltanuska Sep 17, 2013

Yes, the last commit - #2991

pavoltanuska commented Sep 17, 2013

Yes, the last commit - #2991

philsturgeon pushed a commit that referenced this issue Sep 17, 2013

Phil Sturgeon
Merge pull request #2991 from pavoltanuska/fix-2961-uninitialized-var…
…-time

Fix #2961: changed uninitialized var time to thumb_modified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment