New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem on Fields.php cannot use stdObject as an array #3084

Closed
nicolasbistolfi opened this Issue Nov 7, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@nicolasbistolfi

nicolasbistolfi commented Nov 7, 2013

The file Fields.php on system/cms/modules/streams_core/libraries/Fields.php has some problems with validation, so you just need to add is_array($_POST) before doing isset($_POST[$stream_field->field_slug]) on line 381 for example.

I've already did that on my File.php https://dl.dropboxusercontent.com/u/20596750/code/php/Fields.php

Thanks for everything guys!

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Nov 7, 2013

Member

Which version does this relate to?

Any chance you can send this as a pull request to the right branch?

Member

philsturgeon commented Nov 7, 2013

Which version does this relate to?

Any chance you can send this as a pull request to the right branch?

@nicolasbistolfi

This comment has been minimized.

Show comment
Hide comment
@nicolasbistolfi

nicolasbistolfi commented Nov 7, 2013

Done #3085

@obrignoni

This comment has been minimized.

Show comment
Hide comment
@obrignoni

obrignoni Nov 7, 2013

Contributor

If this PR is intended for 2.3/develop, the problem has to be solved elsewhere because the Fields library is being deprecated in favor of the new found at Pyro\Module\Streams_core\Core\Field\FormBuilder. This is because the entire Streams system has been rewritten.

We still need to work on backwards compatibility in the case that devs still use the old streams drivers in 2.3.

@Zantes, Tell us what version of Pyro you are using and what module (or specific file) are you finding this issue. We will either point you in the right direction to fix it or we will eventually fix it. If this is happening with a custom module you'll have to wait until we finish work on backwards compatibility.

Contributor

obrignoni commented Nov 7, 2013

If this PR is intended for 2.3/develop, the problem has to be solved elsewhere because the Fields library is being deprecated in favor of the new found at Pyro\Module\Streams_core\Core\Field\FormBuilder. This is because the entire Streams system has been rewritten.

We still need to work on backwards compatibility in the case that devs still use the old streams drivers in 2.3.

@Zantes, Tell us what version of Pyro you are using and what module (or specific file) are you finding this issue. We will either point you in the right direction to fix it or we will eventually fix it. If this is happening with a custom module you'll have to wait until we finish work on backwards compatibility.

@RyanThompson

This comment has been minimized.

Show comment
Hide comment
@RyanThompson

RyanThompson Nov 7, 2013

Member

Yep I'll rewrite the drivers to use new streams shortly

Member

RyanThompson commented Nov 7, 2013

Yep I'll rewrite the drivers to use new streams shortly

@nicolasbistolfi

This comment has been minimized.

Show comment
Hide comment
@nicolasbistolfi

nicolasbistolfi Nov 7, 2013

I found the bug in the pyrocms-pyrocms-v2.2.3-0-g08759da and solved in my
fork.

Nico Bistolfi
@nicolasbistolfi http://twitter.com/nicolasbistolfi

On Thu, Nov 7, 2013 at 7:24 PM, Ryan Thompson notifications@github.comwrote:

Yep I'll rewrite the drivers to use new streams shortly


Reply to this email directly or view it on GitHubhttps://github.com//issues/3084#issuecomment-28007814
.

nicolasbistolfi commented Nov 7, 2013

I found the bug in the pyrocms-pyrocms-v2.2.3-0-g08759da and solved in my
fork.

Nico Bistolfi
@nicolasbistolfi http://twitter.com/nicolasbistolfi

On Thu, Nov 7, 2013 at 7:24 PM, Ryan Thompson notifications@github.comwrote:

Yep I'll rewrite the drivers to use new streams shortly


Reply to this email directly or view it on GitHubhttps://github.com//issues/3084#issuecomment-28007814
.

@obrignoni

This comment has been minimized.

Show comment
Hide comment
@obrignoni

obrignoni Nov 7, 2013

Contributor

Closing

You are aware that in the PR you sent you were using version 2.3 right? If you have a fix for 2.2.3 please submit to the right branch.

Thank you

Contributor

obrignoni commented Nov 7, 2013

Closing

You are aware that in the PR you sent you were using version 2.3 right? If you have a fix for 2.2.3 please submit to the right branch.

Thank you

@obrignoni obrignoni closed this Nov 7, 2013

nicolasbistolfi added a commit to nicolasbistolfi/pyrocms that referenced this issue Nov 7, 2013

philsturgeon pushed a commit that referenced this issue Apr 28, 2014

Phil Sturgeon
Merge pull request #3086 from zantez/2.2/develop
issue #3084 solved, bug cannot use a stdObject as an array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment