support for symlinks in assets #1295

Merged
merged 3 commits into from Apr 13, 2012

Conversation

Projects
None yet
3 participants

The Asset_Cssurirewriter fails if you use symlinks in your document root (which I do a lot).
But you can provide the rewrite() method a list of symlink-ed directories. So I added the neccessary stuff to be able to do that in a more pyrocms way.

And sorry for all the pull requests. I still suck at using git, especially when having to change something i comitted. But it will get better eventually :)

Marco Grueter
support for symlinks in assets
support for symlinks in assets

canton7 commented Apr 5, 2012

Ideally, the CSS URI Rewriter should be rewritten to use relative (rather than absolute) URLS, e.g.
this, which would sidestep this problem. However, I don't rate my chances of not breaking some obscure edge case, which makes me reluctant to make the change.

For now, this patch is the best solution.

oh man, sorry for that. Had it correct on my local branch, but did a half-ass job with comitting and pushing it to the remote repo.

jerel added a commit that referenced this pull request Apr 13, 2012

@jerel jerel merged commit 3149b01 into pyrocms:2.1/develop Apr 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment