Feature/initial folder contents #1552

Merged
merged 6 commits into from Jul 24, 2012

Conversation

Projects
None yet
4 participants
Owner

RyanThompson commented Jun 28, 2012

Added a way to load an initial folder rather than the root.

Example: www.yoursite.com/admin/files/initial_folder_contents/FOLDER_ID

Will load the folder_id upon doc.ready and will keep the URL clean and sexy.

Hey Ryan,

Can you provide some more information on this and what it does?

Adam

Owner

RyanThompson commented Jul 5, 2012

This allows you to go to admin/files/initial_folder/ID and it will redirect you to admin/files and load the folder ID passed rather than your root folder. So you can link directly to it.

Ryan Thompson
President / CEO
AI Web Systems, Inc.
(877) 705-0806
www.aiwebsystems.com

Sent from my iPad

On Jul 4, 2012, at 10:49 PM, Adam Fairholm reply@reply.github.com wrote:

Hey Ryan,

Can you provide some more information on this and what it does?

Adam


Reply to this email directly or view it on GitHub:
#1552 (comment)

Member

jerel commented Jul 22, 2012

Am I just being picky if I say that it should grab the id using JavaScript instead of redirecting? My thought was to format the url like so: site.com/admin/files#100 Then parse it via JS and load the specified folder or else the root folder if none was found

Owner

RyanThompson commented Jul 22, 2012

I thought he same initially. But any subsequent reloads would trigger he same result, then unwanted though.

You're too picky. ;-)

Ryan Thompson
President / CEO
AI Web Systems

Sent from my U.S. Cellular® Android-powered phone

Jerel Unruh reply@reply.github.com wrote:

Am I just being picky if I say that it should grab the id using JavaScript instead of redirecting? My thought was to format the url like so: site.com/admin/files#100 Then parse it via JS and load the specified folder or else the root folder if none was found


Reply to this email directly or view it on GitHub:
#1552 (comment)

ryun commented Jul 22, 2012

How about using pushState history,js

I used this in my forum module i'v been working on for ajax pagination,

Owner

RyanThompson commented Jul 22, 2012

I'd just assume keep it simple. Redirect works as a user would expect while not invading other areas such as the URL or page reloads. Nice and out of the way ^_^

I am formally ducking out of this PR because I honestly have no clue what it does, haha. BUT that's only because I am not a files module guy. I am leaving it to Jerel to merge as he pleases.

  • Adam
Owner

RyanThompson commented Jul 24, 2012

We keeping this er what @jerel lol

jerel added a commit that referenced this pull request Jul 24, 2012

@jerel jerel merged commit 0efb533 into pyrocms:2.2/develop Jul 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment