New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in admin nav controller when trying to flush buffer when there was none #2921

Merged
merged 1 commit into from May 5, 2014

Conversation

Projects
None yet
4 participants
@james2doyle

james2doyle commented Aug 8, 2013

fix error in admin nav controller when trying to flush buffer when there was none

@madbonkey

This comment has been minimized.

Show comment
Hide comment
@madbonkey

madbonkey Aug 28, 2013

This works, you guys should merge it in. It's hard enough to get clients to edit Navigation items by themselves without that big fat PHP error 😁

madbonkey commented Aug 28, 2013

This works, you guys should merge it in. It's hard enough to get clients to edit Navigation items by themselves without that big fat PHP error 😁

@james2doyle

This comment has been minimized.

Show comment
Hide comment
@james2doyle

james2doyle Aug 28, 2013

Yeah I have a client on 2.2/develop with this patch and everything is golden

james2doyle commented Aug 28, 2013

Yeah I have a client on 2.2/develop with this patch and everything is golden

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Sep 15, 2013

Member

This PR needs to be updated as it has conflicts. Also if you're fixing issues can you please reference the issue number, so I don't have to go hunting to find it :)

Member

philsturgeon commented Sep 15, 2013

This PR needs to be updated as it has conflicts. Also if you're fixing issues can you please reference the issue number, so I don't have to go hunting to find it :)

philsturgeon pushed a commit that referenced this pull request Sep 19, 2013

RyanThompson pushed a commit that referenced this pull request May 5, 2014

Ryan Thompson
Merge pull request #2921 from james2doyle/2.2/fix-nav-ob-end-clean
fix error in admin nav controller when trying to flush buffer when there was none

@RyanThompson RyanThompson merged commit 00712ab into pyrocms:2.2/develop May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment