New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to turn Accept-language on/off #3275

Merged
merged 5 commits into from May 6, 2014

Conversation

Projects
None yet
3 participants
@ipimpat

ipimpat commented Apr 18, 2014

Added a new configuration key to system/cms/config/language.php config file, which makes it possible to disable Accept-language check in system/cms/hooks/pick_language.php hook

@philsturgeon

View changes

Show outdated Hide outdated system/cms/config/language.php.orig Outdated
Delete language.php.orig
Removed git artifact
@ipimpat

This comment has been minimized.

Show comment
Hide comment
@ipimpat

ipimpat commented Apr 27, 2014

reference: #444

@ipimpat ipimpat referenced this pull request Apr 27, 2014

Closed

Site default lang #444

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon Apr 28, 2014

Member

Hey @kimse1.

This looks like a promising feature. Could you merge 2.2/develop into your branch, so we can see if the tests pass this time?

Member

philsturgeon commented Apr 28, 2014

Hey @kimse1.

This looks like a promising feature. Could you merge 2.2/develop into your branch, so we can see if the tests pass this time?

@RyanThompson

This comment has been minimized.

Show comment
Hide comment
@RyanThompson

RyanThompson May 5, 2014

Member

@kimse1 can you take a look at this?

Member

RyanThompson commented May 5, 2014

@kimse1 can you take a look at this?

@ipimpat

This comment has been minimized.

Show comment
Hide comment
@ipimpat

ipimpat May 5, 2014

Sorry, I forgot it

Merged now and Travis build pssses

ipimpat commented May 5, 2014

Sorry, I forgot it

Merged now and Travis build pssses

philsturgeon pushed a commit that referenced this pull request May 6, 2014

Phil Sturgeon
Merge pull request #3275 from kimse1/accept-language-disable
Added option to turn Accept-language on/off

@philsturgeon philsturgeon merged commit c1f5043 into pyrocms:2.2/develop May 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ipimpat ipimpat deleted the ipimpat:accept-language-disable branch May 14, 2014

@ipimpat

This comment has been minimized.

Show comment
Hide comment
@ipimpat

ipimpat May 14, 2014

Simple PyroCMS module (event) that sets the language based on first uri segment
https://gist.github.com/kimse1/21e2641147a1d8edae9a

ipimpat commented May 14, 2014

Simple PyroCMS module (event) that sets the language based on first uri segment
https://gist.github.com/kimse1/21e2641147a1d8edae9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment