New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect fix for multiple permissions #3288

Merged
merged 1 commit into from May 5, 2014

Conversation

Projects
None yet
2 participants
@ghost

ghost commented May 3, 2014

Multiselect was not re-setting the "Selected" groups if more then one group was selected. This change will correctly set the selected groups for either scenario. This is when editing a navigation link

Ryan Tait
Multiselect fix for multiple permissions
Multiselect was not re-setting the "Selected" groups if more then one group was selected. This change will correctly set the selected groups for either scenario.

RyanThompson pushed a commit that referenced this pull request May 5, 2014

Ryan Thompson
Merge pull request #3288 from ryantait/patch-1
Multiselect fix for multiple permissions

@RyanThompson RyanThompson merged commit ea86f08 into pyrocms:2.2/master May 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@RyanThompson

This comment has been minimized.

Show comment
Hide comment
@RyanThompson

RyanThompson May 5, 2014

Member

Sweet thanks!

Member

RyanThompson commented May 5, 2014

Sweet thanks!

@philsturgeon

This comment has been minimized.

Show comment
Hide comment
@philsturgeon

philsturgeon May 11, 2014

Member

@ryantait thanks for this. Next time please can send this PR against 2.2/develop? Master is only for releases. :)

Member

philsturgeon commented May 11, 2014

@ryantait thanks for this. Next time please can send this PR against 2.2/develop? Master is only for releases. :)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 11, 2014

My bad! Thanks Phil! I hit the switch and realized I was on the wrong branch!

Thanks,
Ryan

--- Original Message ---

From: "Phil Sturgeon" notifications@github.com
Sent: May 11, 2014 1:06 PM
To: "pyrocms/pyrocms" pyrocms@noreply.github.com
Cc: "Ryan Tait" ryan@ryantait.info
Subject: Re: [pyrocms] Multiselect fix for multiple permissions (#3288)

@ryantait thanks for this. Next time please can send this PR against 2.2/develop? Master is only for releases. :)


Reply to this email directly or view it on GitHub:
#3288 (comment)

ghost commented May 11, 2014

My bad! Thanks Phil! I hit the switch and realized I was on the wrong branch!

Thanks,
Ryan

--- Original Message ---

From: "Phil Sturgeon" notifications@github.com
Sent: May 11, 2014 1:06 PM
To: "pyrocms/pyrocms" pyrocms@noreply.github.com
Cc: "Ryan Tait" ryan@ryantait.info
Subject: Re: [pyrocms] Multiselect fix for multiple permissions (#3288)

@ryantait thanks for this. Next time please can send this PR against 2.2/develop? Master is only for releases. :)


Reply to this email directly or view it on GitHub:
#3288 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment