Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data should not install right under the CMAKE_INSTALL_PREFIX #95

Merged
merged 1 commit into from Mar 16, 2017

Conversation

@k-okada
Copy link
Contributor

k-okada commented Mar 14, 2017

First of all, thanks for developping this pakcage. This is exactly what I need.

Not sure if install/share/<package>/<data> is the right place, but I feel data should not installed under install/<data>

I have confirmed this with https://github.com/pfnet/chainercv/blob/master/setup.py

@asmodehn

This comment has been minimized.

Copy link
Collaborator

asmodehn commented Mar 14, 2017

Thanks for this PR. I didnt have any example with data to test with so far.

I m preparing a next big release of this package pretty soon (a few days - cmake api will change)

I think I ll wait and rebase it later. The next version will have more tests, so feel free to add what you need travis to check for you.

@asmodehn

This comment has been minimized.

Copy link
Collaborator

asmodehn commented Mar 16, 2017

merging this now, since we have to wait a bit longer for 0.2 release anyway...

@asmodehn asmodehn merged commit 5de1f5c into pyros-dev:devel Mar 16, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.