Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flamegraph): fixed tooltip display with color blind palette #1442

Merged
merged 1 commit into from Aug 26, 2022

Conversation

StasDachinsky
Copy link
Contributor

Brief

Changes

  • now tooltip works correct with color blind palette

Concerns

Screen.Recording.2022-08-25.at.17.44.39.mov

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 418.12 KB (-0.01% 🔽) 8.4 s (-0.01% 🔽) 3.3 s (-1.75% 🔽) 11.7 s
webapp/public/assets/app.css 15.4 KB (0%) 308 ms (0%) 0 ms (+100% 🔺) 308 ms
webapp/public/assets/styles.css 9.46 KB (0%) 190 ms (0%) 0 ms (+100% 🔺) 190 ms
packages/pyroscope-flamegraph/dist/index.js 91.63 KB (0%) 1.9 s (0%) 1.6 s (+37.67% 🔺) 3.5 s
packages/pyroscope-flamegraph/dist/index.node.js 91.46 KB (-0.01% 🔽) 1.9 s (-0.01% 🔽) 517 ms (-10.63% 🔽) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 7.05 KB (0%) 141 ms (0%) 0 ms (+100% 🔺) 141 ms

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1442 (90ccbeb) into main (95f83cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   68.51%   68.51%           
=======================================
  Files         129      129           
  Lines        4248     4248           
  Branches     1138     1138           
=======================================
  Hits         2910     2910           
  Misses       1333     1333           
  Partials        5        5           
Impacted Files Coverage Δ
...scope-flamegraph/src/Tooltip/FlamegraphTooltip.tsx 76.39% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dogfrogfog dogfrogfog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eh-am
Copy link
Collaborator

eh-am commented Aug 25, 2022

/create-server

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@Rperry2174 Rperry2174 merged commit 702ad8b into main Aug 26, 2022
@Rperry2174 Rperry2174 deleted the fix/flamegraph-tooltip-palette branch August 26, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants