Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: skip publish npm if user not part of pyroscope org #1594

Merged
merged 13 commits into from
Oct 4, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Oct 4, 2022

Previously when PRs were created by a non member of the pyroscope org, this checkout step would fail, due to the lack of access to the secrets:

image

This PR basically skips the entire pipeline if that secret is not present.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 444.27 KB (0%) 8.9 s (0%) 3.3 s (-1.56% 🔽) 12.1 s
webapp/public/assets/app.css 17.54 KB (0%) 351 ms (0%) 0 ms (+100% 🔺) 351 ms
webapp/public/assets/styles.css 9.5 KB (0%) 191 ms (0%) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 92.19 KB (0%) 1.9 s (0%) 1.5 s (+36.4% 🔺) 3.4 s
packages/pyroscope-flamegraph/dist/index.node.js 92.08 KB (0%) 1.9 s (0%) 531 ms (-14.66% 🔽) 2.4 s
packages/pyroscope-flamegraph/dist/index.css 7.38 KB (0%) 148 ms (0%) 0 ms (+100% 🔺) 148 ms

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 66.53% // Head: 66.53% // No change to project coverage 👍

Coverage data is based on head (d851f19) compared to base (2c3cabe).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files         148      148           
  Lines        5031     5031           
  Branches     1165     1165           
=======================================
  Hits         3347     3347           
  Misses       1679     1679           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am eh-am marked this pull request as ready for review October 4, 2022 18:45
@eh-am eh-am marked this pull request as draft October 4, 2022 18:46
@eh-am eh-am marked this pull request as ready for review October 4, 2022 19:16
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit 34c50b3 into main Oct 4, 2022
@petethepig petethepig deleted the build/skip-publish-if-not-a-member-of-org branch October 4, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants