Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G_Local: EG_sim and seG_sim are scalar #53

Closed
rsbivand opened this issue Apr 29, 2019 · 4 comments

Comments

@rsbivand
Copy link

commented Apr 29, 2019

In Moran_Local(), EI_sim and seI_sim are nx1 arrays, so differentiating the outcome by observation. In G_Local, EG_sim and seG_sim are scalar, in some cases that I've looked at narrowing the z_sim distribution compared to Zs, the analytical distribution.

Was this intended, or should G_Local be reviewed around line 376 in esda/getisord.py? Are there a vectorised sum() and std() methods to apply to an array row-wise?

@sjsrey sjsrey self-assigned this May 1, 2019

@sjsrey

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Thanks for spotting this. It is a bug and was not intentional as the treatment in G_Local() should mirror that of Moran_Local() in the treatment of the z_sim distributions. The original code seems to be a case of a cut and paste error.

Will be submitting a fix shortly.

sjsrey added a commit to sjsrey/esda that referenced this issue May 1, 2019
@rsbivand

This comment has been minimized.

Copy link
Author

commented May 2, 2019

OK, thanks!

ljwolf added a commit that referenced this issue May 2, 2019
Merge pull request #54 from sjsrey/b53
BUG: EG_Sim and seG_sim were incorrectly given as scalars. #53
@weikang9009

This comment has been minimized.

Copy link
Member

commented May 3, 2019

corrected by #54

@weikang9009 weikang9009 closed this May 3, 2019

@rsbivand

This comment has been minimized.

Copy link
Author

commented May 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.