New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guerry example dataset #45

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@slumnitz
Copy link
Member

slumnitz commented May 25, 2018

Add Guerry example dataset to examples in libpysal

add README.md file with information of content and source

@sjsrey

@slumnitz

This comment has been minimized.

Copy link
Member Author

slumnitz commented May 26, 2018

There is one test failure, which seems unrelated to this pull request:

======================================================================
FAIL: test_voronoi_frames (libpysal.cg.tests.test_voronoi.Voronoi)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/steffie/code/libpysal/libpysal/cg/tests/test_voronoi.py", line 27, in test_voronoi_frames
    import geopandas as df
ImportError: dlopen(/Users/steffie/anaconda3/lib/python3.6/site-packages/fiona/ogrext.cpython-36m-darwin.so, 2): Library not loaded: @rpath/libpng16.16.dylib
  Referenced from: /Users/steffie/anaconda3/lib/libgdal.20.dylib
  Reason: Incompatible library version: libgdal.20.dylib requires version 51.0.0 or later, but libpng16.16.dylib provides version 49.0.0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/steffie/code/libpysal/libpysal/cg/tests/test_voronoi.py", line 30, in test_voronoi_frames
    self.assertTrue(isinstance(region, cg.shapes.Polygon))
AssertionError: False is not true

When I run nosetests . locally I get the same failure, in both my branch and in the master branch.

I can import Guerry from libpysal with the changes here, so that all seems to work.

Please let me know if you don't want to merge this, because then I won't change my notebooks in splot yet to import Guerry from libpysal, but will keep a copy of Guerry in splot/examples/.

@sjsrey

This comment has been minimized.

Copy link
Member

sjsrey commented May 29, 2018

The failures are due to some underlying change in gdal, which is a dependency for geopandas. Once this gets sorted, the libpysal tests should pass.

@slumnitz

This comment has been minimized.

Copy link
Member Author

slumnitz commented Jun 19, 2018

seems like the test failure got sorted

@ljwolf ljwolf merged commit 7111d29 into pysal:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment